Deprecate existingDataSeedInstance option to CREATE DATABASE
#1821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace with new option `existingDataSeedServer`
HannesSandberg
requested changes
Sep 20, 2024
| | | ||
| Controls how the system handles existing data on disk when creating the database. | ||
| Currently, this is only supported with `existingDataSeedInstance` and `seedURI`, and must be set to `use`, which indicates the existing data files should be used for the new database. | ||
| Currently, this is only supported with `existingDataSeedInstance`, `existingDataSeedServer` and `seedURI`, and must be set to `use`, which indicates the existing data files should be used for the new database. |
There was a problem hiding this comment.
I can not make a comment above. But we should mention existingDataSeedServer on row 34 as well.
HannesSandberg
approved these changes
Sep 23, 2024
renetapopova
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Thanks, @mnd999. It looks good; I have just two minor suggestions.
modules/ROOT/pages/database-administration/standard-databases/create-databases.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/database-administration/standard-databases/create-databases.adoc
Outdated
Show resolved
Hide resolved
…create-databases.adoc
…create-databases.adoc
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace with new option
existingDataSeedServerDocumenting https://github.com/neo-technology/neo4j/pull/27123